markzz/aurweb.git/web/html/pkgsubmit.php, branch 1.8.2

Remove File_Find PEAR module from code base.

2011-04-05T09:31:12Z

We removed the code depending on this a long time ago - drop it and add some note to "UPGRADING". Signed-off-by: Lukas Fleischer

Remove Dummy Package concept

2011-04-03T20:59:32Z

Instead, we just store dependencies directly in the PackageDepends table. Since we don't use this info anywhere besides the package details page, there is little value in precalculating what is in the AUR vs. what is not. An upgrade path is provided via several SQL statements in the UPGRADING document. There should be no user-visible change from this, but the DB schema gets a bit more sane and we no longer have loads of junk packages in our tables that are never shown to the end user. This should also help the MySQL query planner in several cases as we no longer have to be careful to exclude dummy packages on every query. Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Always set ModifiedTS including new packages

2011-04-03T20:59:31Z

Set it equal to the SubmittedTS field, which will be our indication the package is new when we show the logo on the front page of the AUR. This results in the ability to remove the use of the unindexable GREATEST() function from the AUR code everywhere we had to use it before to handle the 0 timestamp case. Note that there is no race condition here in calling UNIX_TIMESTAMP() twice- it always returns the time at the beginning of statment execution: mysql> select unix_timestamp(), sleep(2), unix_timestamp(); +------------------+----------+------------------+ | unix_timestamp() | sleep(2) | unix_timestamp() | +------------------+----------+------------------+ | 1300851746 | 0 | 1300851746 | +------------------+----------+------------------+ 1 row in set (2.00 sec) Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Submission process code refactor

2011-04-03T20:59:31Z

We had a ton of duplicate code shared between the insert and update cases. Do a refactor so we can pull this stuff out below the if/else block and only need it there once, saving some headaches. Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Be more restrictive with source tarball contents.

2011-03-30T18:49:21Z

Reject tarballs containing more than one directory or files outside a directory. Signed-off-by: Lukas Fleischer

Fix PHP notice when submitting an empty file.

2011-03-30T14:16:27Z

Signed-off-by: Lukas Fleischer

Fix strict standards warnings in "web/html/pkgsubmit.php".

2011-03-30T10:28:17Z

end() expects a reference but we pass a function return value here. Using list() is a bit hacky as well as it expects a 0-based array whereas unpack() returns a 1-based array - thus we use "list(, $foo)". Signed-off-by: Lukas Fleischer

Check if submitted files are in GZIP format.

2011-03-30T09:55:32Z

This is quite hacky but this way we can ensure users get comprehensible error messages when trying to upload ".tar.xz" or ".tar.bz2" files. Signed-off-by: Lukas Fleischer

Define "Packages.SubmitterUID" and "Packages.MaintainerUID" as "NULL".

2011-02-27T18:46:19Z

Signed-off-by: Lukas Fleischer

Reject blacklisted packages on initial submission only.

2011-02-25T10:18:02Z

Signed-off-by: Lukas Fleischer