markzz/aurweb.git/web/html/pkgsubmit.php, branch v1.9.1

Wrap mysql_real_escape_string() in a function

2011-10-25T07:25:30Z

Wrap mysql_real_escape_string() in a wrapper function db_escape_string() to ease porting to other databases, and as another step to pulling more of the database code into a central location. This is a rebased version of a patch by elij submitted about half a year ago. Thanks-to: elij Signed-off-by: Lukas Fleischer Conflicts: web/lib/aur.inc.php

web/html/pkgsubmit.php: Deal with unset category ID

2011-09-05T14:47:59Z

Do not move the package to the incoming package directory and fail to create proper database entries if some AUR upload helper doesn't provide a category. We got several failing constraints here, such as: Cannot add or update a child row: a foreign key constraint fails (`AUR`.`Packages`, CONSTRAINT `Packages_ibfk_1` FOREIGN KEY (`CategoryID`) REFERENCES `PackageCategories` (`ID`) ON DELETE NO ACTION) Instead, default to "1" (which is "none", or "keep category" for existing packages) if no category is supplied. Signed-off-by: Lukas Fleischer

Make package creation and update atomic

2011-08-11T14:17:08Z

Add BEGIN and COMMIT statements where it makes sense to do so. This allows the entire package creation or update process to be atomic and not be seen until it is complete. Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Rename package_exists() to pkgid_from_name()

2011-08-11T14:17:07Z

Describe what this function actually does: Return the ID of a package with a given name and return NULL if such a package doesn't exist. The function name is chosen in a fashion similar to other functions from "pkgfuncs.inc.php" (pkgname_from_id(), pkgnotify_from_sid(), ...). Signed-off-by: Lukas Fleischer

Segment the upload directory by package name prefix

2011-08-10T12:34:07Z

This implements the following scheme: * /packages/cower/ --> /packages/co/cower/ * /packages/j/ --> /packages/j/j/ * /packages/zqy/ --> /packages/zq/zqy/ We take up to the first two characters of each package name as a intermediate subdirectory, and then the full package name lives underneath that. Shorter named packages live in a single letter directory. Why, you ask? Well because earlier today the AUR hit 32,000 entries in the unsupported/ directory, making new package uploads impossible. While some might argue we shouldn't have so many damn packages in the repos, we should be able to handle this case. Why two characters instead of one? Our two biggest two-char groups, 'pe' and 'py', both start with 'p', and have nearly 2000 packages each. Go Python and Perl. Still needed is a "move the existing data" script, as well as a set of rewrite rules for those wishing to preserve backward compatible URLs for any helper programs doing the wrong thing and relying on them. Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Fix empty depends database insert

2011-07-29T21:51:29Z

Do not try to insert a falsey value into the database in case of "depends=()". Signed-off-by: Manuel Signed-off-by: Lukas Fleischer

Replace split() invocations with explode()

2011-06-28T06:55:47Z

Do not use split(), which has been deprecated as of PHP 5.3.0. As we don't even require regular expressions here, just use explode() instead. Signed-off-by: Lukas Fleischer

Honor epoch field in PKGBUILD files.

2011-06-25T09:29:56Z

The epoch field in PKGBUILD files was completely ignored until now, and the final Version field for a package consisted only of pkgver and pkgrel (example: 5.0-1) This means that rpc.php reported the version incorrectly for packages having epoch > 0. One case where this was a problem is that it confused AUR helpers wanting to examine all locally installed packages (with epoch > 0) and search the AUR for an updated version. The epoch field is taken into consideration now, and if not 0, will be prepended to the final Version field (example: 1:5.0-1) Signed-off-by: Lukas Fleischer

rename .inc files to .inc.php and adjust imports and references

2011-06-22T13:15:04Z

Lukas: Add note to "UPGRADING". Signed-off-by: Lukas Fleischer

SQL: treat all UID/ID values as numbers, not strings

2011-04-27T12:50:27Z

Ensure we are not quoting these values in any of our SQL queries. Thanks-to: elij Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer