markzz/aurweb.git/web/lib/pkgfuncs.inc.php, branch v1.9.0

Remove unnecessary atype and uid lookup from package_details()

2011-08-11T14:17:09Z

These were never used in the function. Where they are used is in the pkg_details.php template, so move them closer to their actual usage so as not to confuse poor programmers such as myself. Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Use 'true' instead of 'True' everywhere

2011-08-11T14:17:09Z

Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

pkgfuncs.inc.php: allow all DB funcs to take handle arg

2011-08-11T14:17:08Z

Allows handle reuse if one is available. Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Add "mergepkgid" argument to pkg_delete()

2011-08-11T14:17:07Z

This allows for merging comments and votes of deleted packages into another one which is useful if a package needs to be renamed. Signed-off-by: Lukas Fleischer Signed-off-by: Dan McGee

Rename package_exists() to pkgid_from_name()

2011-08-11T14:17:07Z

Describe what this function actually does: Return the ID of a package with a given name and return NULL if such a package doesn't exist. The function name is chosen in a fashion similar to other functions from "pkgfuncs.inc.php" (pkgname_from_id(), pkgnotify_from_sid(), ...). Signed-off-by: Lukas Fleischer

Use sane ORDER BY clauses in package list queries

2011-06-25T09:29:55Z

We were doing some silly things here with an "ORDER BY Name, CategoryID" clause, due to the fact that Name is unique, and thus any additional ordering after Name will have no effect. Of course, the dumb as a box of rocks MySQL query optimizer doesn't realize this, leading to full table scans every time of ~30000 packages instead of using index scans for the ordering and only retrieving the first 50 rows. The biggest change is noted in the default sort order as it cuts down the columns to one, but we can remove the redundant sort from other orderings as well, even though those will still not be able to use an index-driven query plan. Signed-off-by: Dan McGee Signed-off-by: Lukas Fleischer

Do not redirect on single search results

2011-06-22T13:42:38Z

The use of header() to redirect after previous output was a design flaw. Our only luck here was PHP's "output_buffering" config variable defaulting to 4096, which kind of hid the bug for a long time. Fixes FS#24580. Signed-off-by: Lukas Fleischer

rename .inc files to .inc.php and adjust imports and references

2011-06-22T13:15:04Z

Lukas: Add note to "UPGRADING". Signed-off-by: Lukas Fleischer